Ok friend, I think I can offer some insight.
First, don't blame yourself for whatever transpired between you and your dad. That will get you absolutely nowhere.
Enjoy those positive memories you have and forget the rest. Because some of us didn't have a father to have a relationship with in the first place. Like you, I have fought with some demons over a relationship with a father that I never had. At least you had something. Take the good parts and be happy about them. Be proud of those things. You have something there to hold on to.
No matter how much you may struggle with these things remember, there is always someone who has it worse.
Share the best of those things with your son. No need to share the dirt with him.
And then just be the best father you can be and build a better chain for the future. This I know you can do
